Snippets for 4pane 8.0 from Fedora i686
Sourced from https://kojipkgs.fedoraproject.org/packages/4Pane/8.0/17.fc45/data/logs/i686/build.log.
-
ArchiveStream.h:139:35: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation] 139 | for (size_t n=0; n<FileCount(); ++n) if (filedataarray->Item(n)->GetFilename() == filename) return (FakeFiledata*)filedataarray->Item(n); return NULL; } | ^~~ -
ArchiveStream.h:141:35: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation] 141 | for (size_t n=0; n<SubDirCount(); ++n) if (dirdataarray->Item(n)->GetFilename() == dirname) return true; return false; } | ^~~ -
Devices.h:236:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘unsigned int’} [-Wsign-compare] 236 | for (int n=0; n < GetCount(); ++n) | ~~^~~~~~~~~~~~ -
ArchiveStream.cpp:64:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 64 | if (!candidate->IsDir()) candid = candid.BeforeLast(wxFILE_SEP_PATH); candid += wxFILE_SEP_PATH; // In case this is a file, amputate the filename | ^~ -
ArchiveStream.cpp:1452:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 1452 | if (fd.IsCharDev()) type = wxTAR_CHRTYPE; if (fd.IsBlkDev()) type = wxTAR_BLKTYPE; if (fd.IsFIFO()) type = wxTAR_FIFOTYPE; | ^~ -
ArchiveStream.cpp:1645:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 1645 | if (active->fileview == ISRIGHT) active = active->partner; active->fulltree = WasOriginallyFulltree; // Set the pane's fulltree-ness to its original value | ^~ -
Misc.cpp:351:9: warning: unused variable ‘wt32’ [-Wunused-variable] 351 | int wt, wt32; | ^~~~ -
Filetypes.cpp:1957:14: warning: variable ‘state’ set but not used [-Wunused-but-set-variable=] 1957 | wxMouseState state = wxGetMouseState(); | ^~~~~ -
Devices.cpp:227:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 227 | if (config == NULL) // It'll usually be null, the exception being if coming from ConfigureMisc::OnExportBtn | ^~ -
Devices.cpp:495:26: warning: enum constant in boolean context [-Wint-in-bool-context] 495 | if (ClusterWasNeeded && !myDragCopy) UnRedoManager::EndCluster(); // Don't end the cluster if threads are involved; it'll be too soon | ^~~~~~~~~~ -
Devices.cpp:629:15: warning: unused variable ‘which’ [-Wunused-variable] 629 | static size_t which = 0; // Used to provide an ID number for the buttons | ^~~~~ -
Devices.cpp:1166:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 1166 | if (config==NULL) // It'll usually be null, the exception being if coming from ConfigureMisc::OnExportBtn | ^~ -
Devices.cpp:2861:15: warning: unused variable ‘UserID’ [-Wunused-variable] 2861 | static size_t UserID = getuid(); | ^~~~~~ -
Devices.cpp:2900:6: warning: unused variable ‘alreadyKnown’ [-Wunused-variable] 2900 | bool alreadyKnown(false); | ^~~~~~~~~~~~ -
Devices.cpp:3300:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3300 | if (config == NULL) // It'll usually be null, the exception being if coming from ConfigureMisc::OnExportBtn | ^~ -
Configure.cpp:2616:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 2616 | if (fdlg.ShowModal() == wxID_OK) ((wxTextCtrl*)GetPage(UDCAddTool)->FindWindow(wxT("UDCFilepath")))->SetValue(fdlg.GetPath()); return; | ^~ -
Configure.cpp:3833:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3833 | if (config==NULL) // It'll usually be null, the exception being if coming from ConfigureMisc::OnExportBtn | ^~ -
Configure.cpp:4069:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 4069 | if (config==NULL) // It'll usually be null, the exception being if coming from ConfigureMisc::OnExportBtn | ^~ -
MyDirs.cpp:728:11: warning: unused variable ‘stat’ [-Wunused-variable] 728 | DataBase* stat; bool IsArchive = arcman && arcman->IsArchive(); | ^~~~ -
MyDirs.cpp:945:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 945 | if (UnRedoManager::ClusterIsOpen) UnRedoManager::EndCluster(); return; | ^~ -
MyDirs.cpp:963:11: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 963 | if (UnRedoManager::ClusterIsOpen) UnRedoManager::EndCluster(); return; | ^~ -
MyDirs.cpp:1559:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 1559 | { if (!PathName->GetFullName().IsEmpty()) // and providing there IS a "filename" | ^~ -
MyGenericDirCtrl.cpp:651:4: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 651 | else | ^~~~ -
MyGenericDirCtrl.cpp:951:1: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 951 | if (fileview == ISLEFT) // // if we're supposed to be showing directories, rather than files | ^~ -
MyGenericDirCtrl.cpp:1292:117: warning: ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool-context] 1292 | int imageindex = 0 + (GDC_ghostclosedfolder * IsArchv) + (!IsArchv && access(path.mb_str(wxConvUTF8), R_OK) * GDC_lockedfolder); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ -
MyGenericDirCtrl.cpp:1616:1: warning: ‘nonnull’ argument ‘this’ compared to NULL [-Wnonnull-compare] 1616 | if(!this) return invalid; // in case we arrived here when there aren't any tabs | ^~ -
MyFiles.cpp:124:27: warning: conversion from ‘long long unsigned int’ to ‘long unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] 124 | if (((*first)->sortULL == (wxULongLong_t)-1) || ((*second)->sortULL == (wxULongLong_t)-1) | ^~~~~~~~~~~~~~~~~ -
MyFiles.cpp:124:72: warning: conversion from ‘long long unsigned int’ to ‘long unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] 124 | if (((*first)->sortULL == (wxULongLong_t)-1) || ((*second)->sortULL == (wxULongLong_t)-1) | ^~~~~~~~~~~~~~~~~ -
MyFiles.cpp:137:27: warning: conversion from ‘long long unsigned int’ to ‘long unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] 137 | if (((*first)->sortULL == (wxULongLong_t)-1) || ((*second)->sortULL == (wxULongLong_t)-1) | ^~~~~~~~~~~~~~~~~ -
MyFiles.cpp:137:72: warning: conversion from ‘long long unsigned int’ to ‘long unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] 137 | if (((*first)->sortULL == (wxULongLong_t)-1) || ((*second)->sortULL == (wxULongLong_t)-1) | ^~~~~~~~~~~~~~~~~ -
MyFiles.cpp:150:27: warning: conversion from ‘long long unsigned int’ to ‘long unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] 150 | if (((*first)->sortULL == (wxULongLong_t)-1) || ((*second)->sortULL == (wxULongLong_t)-1) | ^~~~~~~~~~~~~~~~~ -
MyFiles.cpp:150:72: warning: conversion from ‘long long unsigned int’ to ‘long unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] 150 | if (((*first)->sortULL == (wxULongLong_t)-1) || ((*second)->sortULL == (wxULongLong_t)-1) | ^~~~~~~~~~~~~~~~~ -
MyFiles.cpp:163:27: warning: conversion from ‘long long unsigned int’ to ‘long unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] 163 | if (((*first)->sortULL == (wxULongLong_t)-1) || ((*second)->sortULL == (wxULongLong_t)-1) | ^~~~~~~~~~~~~~~~~ -
MyFiles.cpp:163:72: warning: conversion from ‘long long unsigned int’ to ‘long unsigned int’ changes value from ‘18446744073709551615’ to ‘4294967295’ [-Woverflow] 163 | if (((*first)->sortULL == (wxULongLong_t)-1) || ((*second)->sortULL == (wxULongLong_t)-1) | ^~~~~~~~~~~~~~~~~ -
MyFiles.cpp:1343:24: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 1343 | else array.Sort((*CompareFunc)); break; | ^~~~ -
MyFiles.cpp:1349:24: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 1349 | else array.Sort(SortULLCompareFunction); break; | ^~~~ -
MyFiles.cpp:1355:24: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 1355 | else array.Sort(SortintCompareFunction); break; | ^~~~ -
MyFiles.cpp:1361:24: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 1361 | else array.Sort((*CompareFunction)); break; | ^~~~ -
MyFiles.cpp:1369:24: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 1369 | else array.Sort((*CompareFunction)); break; | ^~~~ -
MyFiles.cpp:1377:24: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 1377 | else array.Sort((*CompareFunction)); break; | ^~~~ -
MyTreeCtrl.cpp:1198:26: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 1198 | else parent->OnDnDMove(); break;} // Otherwise do a Move as requested | ^~~~ -
sdk/rsvg/rsvg.cpp:94:7: warning: unused variable ‘width’ [-Wunused-variable] 94 | int width = -1; | ^~~~~ -
sdk/rsvg/rsvg.cpp:95:7: warning: unused variable ‘height’ [-Wunused-variable] 95 | int height = -1; | ^~~~~~ -
MyFrame.cpp:331:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 331 | if (wxGetKeyState(WXK_CONTROL)) flags |= wxACCEL_CTRL; if (wxGetKeyState(WXK_ALT)) flags |= wxACCEL_ALT; if (wxGetKeyState(WXK_SHIFT)) flags |= wxACCEL_SHIFT; | ^~ -
MyFrame.cpp:821:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 821 | if (button) button->Destroy(); continue; | ^~ -
MyFrame.cpp:1947:13: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 1947 | if (Layout->CommandlineShowing) Layout->commandline->SetFocus(); return; | ^~ -
MyFrame.cpp:1949:13: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 1949 | if (m_tbText->IsShown()) m_tbText->SetFocus(); return; | ^~ -
Redo.cpp:1392:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 1392 | { if (!PathName->GetFullName().IsEmpty()) // and providing there IS a "filename" | ^~ -
Tools.cpp:212:5: warning: this ‘while’ clause does not guard... [-Wmisleading-indentation] 212 | { while (HasInput()); // Flush out any outstanding results before we boast | ^~~~~ -
Tools.cpp:219:9: warning: this ‘while’ clause does not guard... [-Wmisleading-indentation] 219 | { while (HasInput()); | ^~~~~ -
Tools.h:269:16: warning: ‘Tools::Layout’ will be initialized after [-Wreorder] 269 | LayoutWindows* Layout; | ^~~~~~ -
Tools.h:268:16: warning: ‘MyBottomPanel* Tools::bottom’ [-Wreorder] 268 | MyBottomPanel* bottom; | ^~~~~~ -
Tools.cpp:275:1: warning: when initialized here [-Wreorder] 275 | Tools::Tools(LayoutWindows* layout) : Layout(layout), bottom(NULL) | ^~~~~ -
Tools.cpp:2414:30: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘unsigned int’} and ‘long int’ [-Wsign-compare] 2414 | if (GetCurrentPrompt().Len() > from) return ""; // Abort if we're within the prompt | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ -
Tools.cpp:3390:6: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] 3390 | else | ^~~~ -
Tools.cpp:3586:35: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3586 | if (IP < GetLastPosition()) Remove(IP, IP+1); return; | ^~ -
Tools.cpp:3592:35: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 3592 | if (IP > 0) Remove(IP-1, IP); return; | ^~