Snippets for openssh 10.5p1 from Fedora i686

Sourced from https://kojipkgs.fedoraproject.org/packages/openssh/10.5p1/1.fc46/data/logs/i686/build.log.

• base64.c:212:21: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    212 |                 pos = strchr(Base64, ch);
        |                     ^
  

• log.c:604:58: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘time_t’ {aka ‘long int’} [-Wsign-compare]
    604 |                         if (olast_event + rl->hysteresis < now) {
        |                                                          ^
  

• log.c:611:66: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘time_t’ {aka ‘long int’} [-Wsign-compare]
    611 |                 } else if (rl->hysteresis_start + rl->hysteresis < now) {
        |                                                                  ^
  

• log.c:649:38: warning: comparison of integer expressions of different signedness: ‘time_t’ {aka ‘long int’} and ‘long unsigned int’ [-Wsign-compare]
    649 |         if (rl->log_every > 0 && now >= rl->last_log + rl->log_every) {
        |                                      ^~
  

• log.c:402:53: warning: ‘: ’ directive output may be truncated writing 2 bytes into a region of size between 1 and 1024 [-Wformat-truncation=]
    402 |                 snprintf(fmtbuf, sizeof(fmtbuf), "%s: %s", msgbuf, suffix);
        |                                                     ^~
  

• match.c:283:24: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    283 |                 if ((p = strrchr(pattern, '@')) != NULL &&
        |                        ^
  

• hostfile.c:93:16: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     93 |         if ((p = memchr(s, HASH_DELIM, l)) == NULL) {
        |                ^
  

• hostfile.c:525:16: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    525 |         if ((p = strrchr(filename, '/')) == NULL)
        |                ^
  

• getopt_long.c:441:18: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    441 |             (oli = strchr(options, optchar)) == NULL) {
        |                  ^
  

• port-linux.c:68:1: warning: ‘ssh_selinux_getctxbyname’ defined but not used [-Wunused-function]
     68 | ssh_selinux_getctxbyname(char *pwname)
        | ^~~~~~~~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:67:1: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
     67 | sshd_selinux_send_audit_message(int success, security_context_t default_context,
        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:68:24: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
     68 |                        security_context_t selected_context)
        |                        ^~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:114:1: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    114 | mls_range_allowed(security_context_t src, security_context_t dst)
        | ^~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:114:1: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
  

• port-linux-sshd.c:141:9: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    141 |         security_context_t *sc) {
        |         ^~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:179:17: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    179 |                 security_context_t obtained_raw;
        |                 ^~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:180:17: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    180 |                 security_context_t requested_raw;
        |                 ^~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:239:1: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    239 | sshd_selinux_getctxbyname(char *pwname, security_context_t *default_sc,
        | ^~~~~~~~~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:240:5: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    240 |     security_context_t *user_sc, int inetd, Authctxt *the_authctxt)
        |     ^~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:271:25: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    271 |                         security_context_t sshdsc=NULL;
        |                         ^~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:292:33: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    292 |                                 security_context_t default_level_sc = *default_sc;
        |                                 ^~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:385:9: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    385 |         security_context_t user_ctx = NULL;
        |         ^~~~~~~~~~~~~~~~~~
  

• port-linux-sshd.c:387:9: warning: ‘security_context_t’ is deprecated [-Wdeprecated-declarations]
    387 |         security_context_t default_ctx = NULL;
        |         ^~~~~~~~~~~~~~~~~~
  

• gss-genr.c:132:32: warning: unused variable ‘md’ [-Wunused-variable]
    132 |         struct ssh_digest_ctx *md = NULL;
        |                                ^~
  

• gss-genr.c:182:30: warning: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
    182 |                         cp = strncpy(s, kex, strlen(kex));
        |                              ^
  

• misc.c:1399:37: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   1399 |                         if ((varend = strchr(string, '}')) == NULL) {
        |                                     ^
  

• misc.c:775:40: warning: ‘%02llu’ directive output may be truncated writing between 2 and 14 bytes into a region of size 9 [-Wformat-truncation=]
    775 |                 snprintf(buf, TF_LEN, "%02lluw%01ud%02uh", week, day, hrs);
        |                                        ^~~~~~
  

• kexgssc.c:618:28: warning: comparison of integer expressions of different signedness: ‘int’ and ‘u_int’ {aka ‘unsigned int’} [-Wsign-compare]
    618 |         if (BN_num_bits(p) < kex->min || BN_num_bits(p) > kex->max)
        |                            ^
  

• kexgssc.c:618:57: warning: comparison of integer expressions of different signedness: ‘int’ and ‘u_int’ {aka ‘unsigned int’} [-Wsign-compare]
    618 |         if (BN_num_bits(p) < kex->min || BN_num_bits(p) > kex->max)
        |                                                         ^
  

• kexmlkem768x25519.c:659:82: warning: passing argument 2 of ‘OSSL_PARAM_construct_utf8_string’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    659 |         params[0] = OSSL_PARAM_construct_utf8_string(OSSL_PKEY_PARAM_GROUP_NAME, curve_name, 0);
        |                                                                                  ^~~~~~~~~~
  

• kexmlkem768x25519.c:739:82: warning: passing argument 2 of ‘OSSL_PARAM_construct_utf8_string’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    739 |         params[0] = OSSL_PARAM_construct_utf8_string(OSSL_PKEY_PARAM_GROUP_NAME, curve_name, 0);
        |                                                                                  ^~~~~~~~~~
  

• ssh-pkcs11-uri.c:138:20: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    138 |                 cp = strchr(allow_list, data[i]);
        |                    ^
  

• clientloop.c:2123:17: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   2123 |         if ((cp = strchr(hosts, ',')) == NULL)
        |                 ^
  

• mux.c:239:17: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    239 |         if ((cp = strchr(env, '=')) == NULL || cp == env)
        |                 ^
  

• ssh-pkcs11.c:579:52: warning: passing argument 1 of ‘pkcs11_lookup_key’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    579 |         struct pkcs11_key *k11 = pkcs11_lookup_key(key);
        |                                                    ^~~
  

• sshd-session.c:1583:20: warning: unused variable ‘auth_attempted’ [-Wunused-variable]
   1583 |         extern int auth_attempted; /* monitor.c */
        |                    ^~~~~~~~~~~~~~
  

• gss-serv-krb5.c:356:16: warning: variable ‘linenum’ set but not used [-Wunused-but-set-variable=]
    356 |         u_long linenum = 0;
        |                ^~~~~~~
  

• misc.h:164:5: warning: ‘bounded’ attribute directive ignored [-Wattributes]
    164 |     __attribute__((__bounded__( __minbytes__, 1, 8)));
        |     ^~~~~~~~~~~~~
  

• misc.h:166:5: warning: ‘bounded’ attribute directive ignored [-Wattributes]
    166 |     __attribute__((__bounded__( __minbytes__, 1, 4)));
        |     ^~~~~~~~~~~~~
  

• misc.h:168:5: warning: ‘bounded’ attribute directive ignored [-Wattributes]
    168 |     __attribute__((__bounded__( __minbytes__, 1, 2)));
        |     ^~~~~~~~~~~~~
  

• misc.h:170:5: warning: ‘bounded’ attribute directive ignored [-Wattributes]
    170 |     __attribute__((__bounded__( __minbytes__, 1, 8)));
        |     ^~~~~~~~~~~~~
  

• misc.h:172:5: warning: ‘bounded’ attribute directive ignored [-Wattributes]
    172 |     __attribute__((__bounded__( __minbytes__, 1, 4)));
        |     ^~~~~~~~~~~~~
  

• misc.h:174:5: warning: ‘bounded’ attribute directive ignored [-Wattributes]
    174 |     __attribute__((__bounded__( __minbytes__, 1, 2)));
        |     ^~~~~~~~~~~~~
  

• misc.h:178:5: warning: ‘bounded’ attribute directive ignored [-Wattributes]
    178 |     __attribute__((__bounded__(__minbytes__, 1, 4)));
        |     ^~~~~~~~~~~~~
  

• misc.h:180:5: warning: ‘bounded’ attribute directive ignored [-Wattributes]
    180 |     __attribute__((__bounded__(__minbytes__, 1, 4)));
        |     ^~~~~~~~~~~~~
  

• scp.c:1545:56: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 2 and 4095 [-Wformat-truncation=]
   1545 |                 (void) snprintf(path, sizeof path, "%s/%s", name, dp->d_name);
        |                                                        ^~
  

• sftp.c:1094:61: warning: ‘%3llu’ directive output may be truncated writing between 3 and 20 bytes into a region of size 16 [-Wformat-truncation=]
   1094 |                 snprintf(s_icapacity, sizeof(s_icapacity), "%3llu%%",
        |                                                             ^~~~~
  

• sftp.c:1101:61: warning: ‘%3llu’ directive output may be truncated writing between 3 and 20 bytes into a region of size 16 [-Wformat-truncation=]
   1101 |                 snprintf(s_dcapacity, sizeof(s_dcapacity), "%3llu%%",
        |                                                             ^~~~~
  

• ssh-keygen.c:1085:55: warning: ‘%s’ directive output may be truncated writing up to 1024 bytes into a region of size 1023 [-Wformat-truncation=]
   1085 |                 snprintf(comment, sizeof comment, "%s@%s", pw->pw_name,
        |                                                       ^~
   1086 |                     hostname);
        |                     ~~~~~~~~                           
  

• ssh-keygen.c:344:41: warning: ‘%s’ directive output may be truncated writing up to 1024 bytes into a region of size 39 [-Wformat-truncation=]
    344 |             "%u-bit %s, converted by %s@%s from OpenSSH",
        |                                         ^~
    345 |             sshkey_size(k), sshkey_type(k),
    346 |             pw->pw_name, hostname);
        |                          ~~~~~~~~        
  

• ssh-keygen.c:3923:55: warning: ‘%s’ directive output may be truncated writing up to 1024 bytes into a region of size 1023 [-Wformat-truncation=]
   3923 |                 snprintf(comment, sizeof comment, "%s@%s", pw->pw_name, hostname);
        |                                                       ^~                ~~~~~~~~
  

• gnome-ssh-askpass3.c:184:17: warning: ‘gtk_widget_modify_fg’ is deprecated: Use 'gtk_widget_override_color' instead [-Wdeprecated-declarations]
    184 |                 gtk_widget_modify_fg(dialog, GTK_STATE_NORMAL, &fg);
        |                 ^~~~~~~~~~~~~~~~~~~~
  

• gnome-ssh-askpass3.c:186:17: warning: ‘gtk_widget_modify_bg’ is deprecated: Use 'gtk_widget_override_background_color' instead [-Wdeprecated-declarations]
    186 |                 gtk_widget_modify_bg(dialog, GTK_STATE_NORMAL, &bg);
        |                 ^~~~~~~~~~~~~~~~~~~~
  

• gnome-ssh-askpass3.c:191:25: warning: ‘gtk_widget_modify_fg’ is deprecated: Use 'gtk_widget_override_color' instead [-Wdeprecated-declarations]
    191 |                         gtk_widget_modify_fg(entry, GTK_STATE_NORMAL, &fg);
        |                         ^~~~~~~~~~~~~~~~~~~~
  

• gnome-ssh-askpass3.c:193:25: warning: ‘gtk_widget_modify_bg’ is deprecated: Use 'gtk_widget_override_background_color' instead [-Wdeprecated-declarations]
    193 |                         gtk_widget_modify_bg(entry, GTK_STATE_NORMAL, &bg);
        |                         ^~~~~~~~~~~~~~~~~~~~
  

• gnome-ssh-askpass3.c:136:21: warning: unused variable ‘failed’ [-Wunused-variable]
    136 |         const char *failed;
        |                     ^~~~~~
  

• gnome-ssh-askpass3.c:243:39: warning: ‘entry’ may be used uninitialized [-Wmaybe-uninitialized]
    243 |                 passphrase = g_strdup(gtk_entry_get_text(GTK_ENTRY(entry)));
        |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• ./openbsd-compat/getopt_long.c:441:18: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
    441 |             (oli = strchr(options, optchar)) == NULL) {
        |                  ^