Snippets for freeipmi 1.6.18 from FreeBSD 150amd64

Sourced from https://pkg-status.freebsd.org/beefy23/data/latest-per-pkg/freeipmi/1.6.18/150amd64-default.log.

• fi_hostlist.c:102:49: warning: comparing a pointer to a null character constant; did you mean to compare to NULL? [-Wpointer-compare]
    102 |   while (**str != '\0' && strchr(sep, **str) != '\0')
        |                                                 ^~~~
        |                                                 (void *)0
  

• fi_hostlist.c:118:51: warning: comparing a pointer to a null character constant; did you mean to compare to NULL? [-Wpointer-compare]
    118 |     while (**str != '\0' && strchr(sep, **str) == '\0')
        |                                                   ^~~~
        |                                                   (void *)0
  

• fi_hostlist.c:123:49: warning: comparing a pointer to a null character constant; did you mean to compare to NULL? [-Wpointer-compare]
    123 |   while (**str != '\0' && strchr(sep, **str) != '\0')
        |                                                 ^~~~
        |                                                 (void *)0
  

• hostlist.c:392:51: warning: comparing a pointer to a null character constant; did you mean to compare to NULL? [-Wpointer-compare]
    392 |     while (**str != '\0' && strchr(sep, **str) != '\0')
        |                                                   ^~~~
        |                                                   (void *)0
  

• hostlist.c:408:55: warning: comparing a pointer to a null character constant; did you mean to compare to NULL? [-Wpointer-compare]
    408 |         while (**str != '\0' && strchr(sep, **str) == '\0')
        |                                                       ^~~~
        |                                                       (void *)0
  

• hostlist.c:413:51: warning: comparing a pointer to a null character constant; did you mean to compare to NULL? [-Wpointer-compare]
    413 |     while (**str != '\0' && strchr(sep, **str) != '\0')
        |                                                   ^~~~
        |                                                   (void *)0
  

• hostlist.c:493:15: warning: expression which evaluates to zero treated as a null pointer constant of type 'char *' [-Wnon-literal-null-conversion]
    493 |     char *p = '\0';
        |               ^~~~
  

• libcommon/ipmi-crypt.c:35:1: warning: 'gcry_thread_cbs' is deprecated [-Wdeprecated-declarations]
     35 | GCRY_THREAD_OPTION_PTHREAD_IMPL;
        | ^
  

• util/ipmi-sensor-util.c:545:10: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
    545 |   dval = abs (m * pow (10, r_exponent));
        |          ^
  

• ipmidetect.c:573:11: warning: taking the absolute value of unsigned type 'unsigned long' has no effect [-Wabsolute-value]
    573 |       if (abs (localtime - tv.tv_sec) < timeout_len)
        |           ^
  

• ipmi-config-category-core-lan6-conf-section.c:129:41: warning: result of comparison of constant -1 with expression of type 'uint8_t' (aka 'unsigned char') is always true [-Wtautological-constant-out-of-range-compare]
    129 |   if (get_address_status_number (value) != -1)
        |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
  

• ipmi-config-category-core-lan6-conf-section.c:809:48: warning: result of comparison of constant -1 with expression of type 'uint8_t' (aka 'unsigned char') is always true [-Wtautological-constant-out-of-range-compare]
    809 |   if (get_static_address_source_number (value) != -1)
        |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
  

• ipmi-config-category-core-lan6-conf-section.c:1249:54: warning: result of comparison of constant -1 with expression of type 'uint8_t' (aka 'unsigned char') is always true [-Wtautological-constant-out-of-range-compare]
   1249 |   if (get_dynamic_address_source_type_number (value) != -1)
        |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
  

• ipmi-config-category-dcmi-dcmi-conf-section.c:142:28: warning: result of comparison of constant 191 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
    142 |       && asset_tag_data[2] == IPMI_DCMI_ASSET_TAG_UTF8_BOM_BYTE2)
        |          ~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• ipmi-config-category-dcmi-dcmi-conf-section.c:141:28: warning: result of comparison of constant 187 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
    141 |       && asset_tag_data[1] == IPMI_DCMI_ASSET_TAG_UTF8_BOM_BYTE1
        |          ~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• ipmi-config-category-dcmi-dcmi-conf-section.c:140:25: warning: result of comparison of constant 239 with expression of type 'char' is always false [-Wtautological-constant-out-of-range-compare]
    140 |   if (asset_tag_data[0] == IPMI_DCMI_ASSET_TAG_UTF8_BOM_BYTE0
        |       ~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• ipmi-sensors.c:624:44: warning: address of array 'state_data->prog_data->args->exclude_record_ids' will always evaluate to 'true' [-Wpointer-bool-conversion]
    624 |           if (state_data->prog_data->args->exclude_record_ids)
        |           ~~  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~